faker icon indicating copy to clipboard operation
faker copied to clipboard

Added skip_warning ability to deprecators for tests

Open keshavbiswa opened this issue 1 year ago • 2 comments

Motivation / Background

Fixes: #2948

This Pull Request has been created because We want the ability to silence output warnings for Deprecated Generators in tests.

Checklist

Before submitting the PR make sure the following are checked:

  • [x] This Pull Request is related to one change. Changes that are unrelated should be opened in separate PRs.
  • [x] Commit message has a detailed description of what changed and why. If this PR fixes a related issue include it in the commit message. Ex: [Fix #issue-number]
  • [x] Tests are added or updated if you fix a bug, refactor something, or add a feature.
  • [x] Tests and Rubocop are passing before submitting your proposed changes.

If you're proposing a new generator or locale:

  • [ ] Double-check the existing generators documentation to make sure the new generator you want to add doesn't already exist.
  • [ ] You've reviewed and followed the Contributing guidelines.

keshavbiswa avatar May 22 '24 05:05 keshavbiswa

@thdaraujo Thanks, I'll take a look at your suggestion and also figure out why you're seeing the deprecation message.

keshavbiswa avatar Jun 13 '24 16:06 keshavbiswa

@thdaraujo @stefannibrasil I have fixed the issue and have updated your requested changes.

keshavbiswa avatar Jun 21 '24 07:06 keshavbiswa

@stefannibrasil Reordered it, I misunderstood earlier

keshavbiswa avatar Jul 02 '24 05:07 keshavbiswa