faker icon indicating copy to clipboard operation
faker copied to clipboard
verified publisher icon faker-ruby

Update Faker::Australia to Faker::Locations::Australia

Open keshavbiswa opened this issue 2 years ago • 3 comments

Motivation / Background

As per the discussion in #2787

This PR updates Faker::Australia to Faker::Locations::Australia to keep it consistent with the directory modules.

Checklist

Before submitting the PR make sure the following are checked:

  • [x] This Pull Request is related to one change. Changes that are unrelated should be opened in separate PRs.
  • [x] Commit message has a detailed description of what changed and why. If this PR fixes a related issue include it in the commit message. Ex: [Fix #issue-number]
  • [x] Tests are added or updated if you fix a bug, refactor something, or add a feature.
  • [x] Tests and Rubocop are passing before submitting your proposed changes.

If you're proposing a new generator:

  • [ ] Open an issue first for discussion before you write any code.
  • [ ] Double-check the existing generators documentation to make sure the new generator you want to add doesn't already exist.
  • [ ] You've reviewed and followed the Documentation guidelines.

keshavbiswa avatar Dec 13 '23 08:12 keshavbiswa

I see now, Thanks for the suggestions. I will make the neccessary changes 👍

keshavbiswa avatar Dec 20 '23 17:12 keshavbiswa

Waiting for #2858 to be merged so I can make necessary changes and merge this.

keshavbiswa avatar Jan 27 '24 03:01 keshavbiswa

Hi @keshavbiswa we've merged https://github.com/faker-ruby/faker/pull/2858.

stefannibrasil avatar Feb 25 '24 21:02 stefannibrasil

Hi @keshavbiswa we've merged #2858.

Time to make changes!

keshavbiswa avatar Feb 26 '24 05:02 keshavbiswa

Updated the changes @thdaraujo

keshavbiswa avatar Mar 17 '24 12:03 keshavbiswa

Forgot the documentation 🤦

keshavbiswa avatar Mar 18 '24 06:03 keshavbiswa

oh, I haven't heard from the author of this PR in a while so this one is up to be worked on next. It's similar to this one. Would you be interested in fixing this one as well? https://github.com/faker-ruby/faker/pull/2857 @keshavbiswa

stefannibrasil avatar Mar 19 '24 15:03 stefannibrasil

oh, I haven't heard from the author of this PR in a while so this one is up to be worked on next. It's similar to this one. Would you be interested in fixing this one as well? #2857 @keshavbiswa

I'll create a new PR for it 👍

keshavbiswa avatar Mar 19 '24 15:03 keshavbiswa