Faisal N Jawdat
Faisal N Jawdat
I started [a branch for dropping 2.7 support](https://github.com/faisal/rubycritic/tree/ruby_3). Once we know what we're doing with _this_ PR, it should be a quick turn to make a PR out of that...
Is it worth integrating the fix from https://github.com/whitesmith/rubycritic/pull/486 ?
This reproduces locally. The feature patch is trivial but I'm trying to figure out why the behavior changed against HEAD.
This behavior no longer happens on Ruby 3.4.
This failure appears to come out of Reek: ``` shell $ reek -v reek 6.4.0 $ cat foo.rb sql =
https://github.com/whitesmith/rubycritic/pull/521
Candidate implementation in https://github.com/whitesmith/rubycritic/pull/514.
This PR updates FakeFS to 3.0: https://github.com/whitesmith/rubycritic/pull/504
It's possible this is actually a regression for running on JRuby, and unrelated to the fakefs update: https://github.com/whitesmith/rubycritic/issues/506
Fixed by https://github.com/whitesmith/rubycritic/pull/526