coffeescript-concat icon indicating copy to clipboard operation
coffeescript-concat copied to clipboard

DRYer code, less indents, default directory

Open B7th opened this issue 9 years ago • 5 comments

Added a bit of functionality by making the directory of the file being concatenated the default one, as well as making it more readable at least in appearance, using right handed expressions, getting rid of doublings as well as curly braces.

B7th avatar Aug 13 '16 10:08 B7th

Hey, thanks for the pull!

It's a bit hard to look at with all the whitespace changes - could you move the whitespace changes to their own pull (I'm definitely open to the change, but I'd really like to do it separately)

fairfieldt avatar Aug 16 '16 21:08 fairfieldt

Sure I made a new patch on another pull request that will do the whitespace, and I think once you accept it this pull should be easier to read, agreed with you on that. Let me know what you think of the changes!

B7th avatar Aug 17 '16 15:08 B7th

Thanks! I'll try to take a look at this stuff tonight.

fairfieldt avatar Aug 18 '16 20:08 fairfieldt

I merged the first patch, minus the require changes - I'd prefer to keep the explicit require calls.

Can you update this pull to remove the whitespace changes? I'd love to get it in.

fairfieldt avatar Aug 23 '16 18:08 fairfieldt

Sure! I made a new pull to keep things separate, I hope this helps :)

B7th avatar Aug 23 '16 19:08 B7th