graph-prototype icon indicating copy to clipboard operation
graph-prototype copied to clipboard

Implement CtxSettings, use instead of BasicSettings.

Open drslebedev opened this issue 1 year ago • 1 comments

This PR includes the implementation of CtxSettings, which will replace the existing BasicSettings.

Several tasks need to be addressed following this PR to fully integrate CtxSettings into the codebase:

  1. Remove Base Settings Class and BasicSettings. The old BasicSettings and its base class need to be removed to eliminate redundancy and avoid confusion.
  2. Eliminate usage of unique_ptr for Block::_settings
  3. Update function names to clearly indicate they are associated with CtxSettings, enhancing code readability.
  4. Expand Unit Testing. Add comprehensive unit tests specifically targeting CtxSettings .
  5. using MatchPredicate = std::function<std::optional<bool>(const pmtv::pmt &, const pmtv::pmt &, std::size_t)>; replace this with the new matcher structure. See here for details.

drslebedev avatar May 22 '24 12:05 drslebedev

Quality Gate Failed Quality Gate failed

Failed conditions
12.5% Coverage on New Code (required ≥ 80%)
5.0% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

sonarqubecloud[bot] avatar May 24 '24 12:05 sonarqubecloud[bot]