graph-prototype
graph-prototype copied to clipboard
Implement CtxSettings, use instead of BasicSettings.
This PR includes the implementation of CtxSettings, which will replace the existing BasicSettings.
Several tasks need to be addressed following this PR to fully integrate CtxSettings into the codebase:
- Remove Base Settings Class and
BasicSettings. The oldBasicSettingsand its base class need to be removed to eliminate redundancy and avoid confusion. - Eliminate usage of
unique_ptrfor Block::_settings - Update function names to clearly indicate they are associated with
CtxSettings, enhancing code readability. - Expand Unit Testing. Add comprehensive unit tests specifically targeting
CtxSettings. -
using MatchPredicate = std::function<std::optional<bool>(const pmtv::pmt &, const pmtv::pmt &, std::size_t)>;replace this with the new matcher structure. See here for details.
Quality Gate failed
Failed conditions
12.5% Coverage on New Code (required ≥ 80%)
5.0% Duplication on New Code (required ≤ 3%)