python-patterns icon indicating copy to clipboard operation
python-patterns copied to clipboard

[Infrastructure] Code coverage

Open gyermolenko opened this issue 6 years ago • 4 comments

As far as I know almost always coverage is used to see "test coverage". For unused branches/variables etc there are linters, dead-code finders (such as vulture or dead).

So I don't think code coverage is important to extent of running run_all.sh script.

I would like to

  • remove run_all.sh
  • collect coverage
    • only for tests
    • only for one python branch (e.g. 3.7) (although it is possible to do coverage run -p and then coverage combine)

gyermolenko avatar Feb 07 '19 14:02 gyermolenko

What's the reasoning behind running it only for a specific Python version (e.g. 3.7)?

faif avatar Feb 08 '19 21:02 faif

What's the reasoning behind running it only for a specific Python version

a bit simpler, I guess. But combining is possible, so nevermind. My biggest concern here is - why run_all.sh at all?

gyermolenko avatar Feb 08 '19 22:02 gyermolenko

I think that the basic idea was to able to run all scripts with one command. Coverage came later. So if we can simplify it by removing the coverage part since it's handled elsewhere, fine by me.

faif avatar Feb 09 '19 23:02 faif

To update on this issue:

  • run_all.sh was removed
  • since removal of py2 support full coverage can be done without combining reports per test environment

So only some simplifications in tox.ini are required to resolve the issue.

gyermolenko avatar Jan 14 '20 09:01 gyermolenko