facultyai
className should not be deprecated
- dash version:
2.0.0 - dash-bootstrap-components version:
1.0.2
What is happening?
All the docs say that className is deprecated in favor of class_name. I realize camelCase is not the Python convention, but Dash Core Components and Dash HTML Components (even 2.0) don't support class_name so this creates an inconsistency.
What should be happening?
Don't deprecate and definitely don't remove the className parameter when Dash is still using it.
Hi @jblang
This change was made because I was told by Plotly Devs that they were doing it themselves in Dash 2.0 and asked if I wouldn't mind making the same change here to maintain consistency across the Dash ecosystem. For some reason that never actually made it into Dash 2.0, but by which point I had already implemented it. I was then advised that the change was still on the roadmap for first party Dash libraries and that I shouldn't revert it, so it exists in dbc v1 in a largely unannounced way save for the slightly alarming docstrings.
Rest assured that I would never deprecate this unless it was done so in Dash first party libraries. If Dash switches I'll follow their lead, if they don't end up making the change after all then I'll update the docstrings.
Perhaps @alexcjohnson can chime in and update on whether this is still on the Dash roadmap?
Yes, still on our roadmap although it continues to get pushed farther out so I can't comment on when we might get to it - PRs welcome if anyone wants to help us along. My apologies @tcbegley for leaving DBC out ahead on this for such a long time!
