MarkdownPreview icon indicating copy to clipboard operation
MarkdownPreview copied to clipboard

Added configurable Gitlab domain.

Open ghost opened this issue 4 years ago • 3 comments

This (partially) closes issues #44 . I have only a Gitlab custom domain to test with, so that's why I cannot provide a similar change for the Github part.

ghost avatar Aug 09 '21 09:08 ghost

@ba-tno thanks for this pull! I'm wondering if it would be useful to make the setting a list and prompt the user for the domain if the setting provides more than one. There may be reasons to use one domain for certain files and another for other files.

This is more a question as I'm just thinking about usefulness.

facelessuser avatar Aug 09 '21 14:08 facelessuser

Sorry, I see now that I botched it by calling self in the class variable... I'll have to take a look again anyways, so I'll see if I can get a list working as well (something similar to the enabled_parsers setting).

ghost avatar Aug 09 '21 16:08 ghost

As things have gone silent on this, I may just end up coming back and refactoring this to address related issues.

facelessuser avatar Sep 03 '21 20:09 facelessuser