beanmachine icon indicating copy to clipboard operation
beanmachine copied to clipboard

Add diagnostic visualization tools

Open ndmlny-qs opened this issue 3 years ago • 15 comments

This commit adds the feature to run diagnostic tools using ArviZ and Bokeh in a Jupyter environment.

  • Added a tools sub-package in the diagnostics package. This new sub-package adds the following files, each for a specific tool that runs ArviZ model diagnostics.

    • autocorrelation
    • effective_sample_size
    • marginal1d
    • marginal2d
    • trace
  • The listed tools above also have two corresponding files, one for types and the other for methods used in the tool.

Resolves #1490

Motivation

Please describe your motivation for the changes. Provide link to any related issues.

Changes proposed

Outline the proposed changes and alternatives considered.

Test Plan

Please provide clear instructions on how the changes were verified. Attach screenshots if applicable.

Types of changes

  • [ ] Docs change / refactoring / dependency upgrade
  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • [ ] My code follows the code style of this project.
  • [ ] My change requires a change to the documentation.
  • [ ] I have updated the documentation accordingly.
  • [ ] I have read the CONTRIBUTING document.
  • [ ] I have added tests to cover my changes.
  • [ ] All new and existing tests passed.
  • [ ] The title of my pull request is a short description of the requested changes.

ndmlny-qs avatar Aug 29 '22 17:08 ndmlny-qs

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@horizon-blue has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar Aug 29 '22 18:08 facebook-github-bot

@ndmlny-qs has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot avatar Aug 29 '22 21:08 facebook-github-bot

@horizon-blue has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar Aug 29 '22 21:08 facebook-github-bot

hmm, linting is still failing, and I believe it is because I forgot to add the copyright notice. Fixing now.

ndmlny-qs avatar Aug 29 '22 21:08 ndmlny-qs

@ndmlny-qs has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot avatar Aug 29 '22 21:08 facebook-github-bot

@ndmlny-qs has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot avatar Aug 29 '22 21:08 facebook-github-bot

@ndmlny-qs has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot avatar Aug 29 '22 21:08 facebook-github-bot

Found a bug that cropped up due to the type changes. It has been fixed in the latest push.

ndmlny-qs avatar Aug 29 '22 21:08 ndmlny-qs

@horizon-blue has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar Aug 29 '22 22:08 facebook-github-bot

@ndmlny-qs has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot avatar Aug 30 '22 22:08 facebook-github-bot

@ndmlny-qs has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot avatar Aug 30 '22 22:08 facebook-github-bot

Thanks @CactusWin for the gpytorch fix. I was struggling with errors from it earlier today.

ndmlny-qs avatar Aug 30 '22 22:08 ndmlny-qs

@ndmlny-qs has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot avatar Aug 30 '22 22:08 facebook-github-bot

@horizon-blue has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar Aug 31 '22 04:08 facebook-github-bot