TensorComprehensions icon indicating copy to clipboard operation
TensorComprehensions copied to clipboard

Always emit the same function signature in codegen_llvm

Open thetheodor opened this issue 7 years ago • 1 comments

thetheodor avatar Feb 20 '18 13:02 thetheodor

On Tue, Feb 20, 2018 at 05:49:58AM -0800, Priya Goyal wrote:

  • void createWrapper(
  •  const std::vector<Halide::ImageParam>& inputs,
    
  •  const std::vector<Halide::OutputImageParam>& outputs,
    
  •  const std::string& fname) {
    
  • CHECK(not inputs.empty());

can you use something like CHECK_NE? this is looking like python atm

CHECK_NE doesn't provide any additional information on booleans. If the boolean value isn't the one you were expecting, then obviously, it was the other one. In fact, I find the output of CHECK_NE confusing on booleans.

skimo

skimo-openhub avatar Feb 20 '18 14:02 skimo-openhub