sapp
sapp copied to clipboard
Github actions fix: Have some output for errors
Pre-submission checklist
- [x] I've ran the following linters locally and fixed lint errors related to the files I modified in this PR
- [x]
black . - [x]
usort format . - [x]
flake8
- [x]
- [x] I've installed dev dependencies
pip install -r requirements-dev.txtand completed the following:- [x] I've ran tests with
./scripts/run-tests.shand made sure all tests are passing
- [x] I've ran tests with
Summary
SARIF expects some information about tooling when there are no issues, SAPP currently doesn't print any information and exits silently in case there are no issues after applying filters.
Github Actions expects the output to conform to SARIF. Hence, return empty results list along with tooling information as expected by SARIF.
For reference, see: https://github.com/facebook/pysa-action/actions/runs/4534111680 is crashing.
Test Plan
Before https://github.com/facebook/pysa-action/actions/runs/4534111680
After
Fixes possible errors from happening in Github workflows that make use of sapp-action or pysa-action