sapp
sapp copied to clipboard
Fix Pyre GitHub Action
Pre-submission checklist
- [x] I've ran the following linters locally and fixed lint errors related to the files I modified in this PR
- [x]
black . - [x]
usort format . - [x]
flake8
- [x]
- [ ] I've installed dev dependencies
pip install -r requirements-dev.txtand completed the following:- [ ] I've ran tests with
./scripts/run-tests.shand made sure all tests are passing
- [ ] I've ran tests with
Nope, sorry.I'm on Windows platform and my virtual machine crashed.But this test will run in GitHub Action tests and we can see if this workflow is successful.(also, this PR shouldn't cause any lint error)
Summary
Pyre workflow failed in this repo for two reasons:
- We need to provide a
is_toplevel_modulefortyping_extensions, as this PR. -
ujsonalso couldn't found caused by a known issue of Pyre: facebook/pyre-check#773
Test Plan
If this PR merged and the issue above fixed, pyre Action workflow should pass.