sapp icon indicating copy to clipboard operation
sapp copied to clipboard

Add pre-commit for sapp and fix lint error before

Open WangGithubUser opened this issue 2 years ago • 0 comments

Pre-submission checklist

  • [x] I've ran the following linters locally and fixed lint errors related to the files I modified in this PR
    • [x] black .
    • [x] usort format .
    • [x] flake8
  • [ ] I've installed dev dependencies pip install -r requirements-dev.txt and completed the following:
    • [ ] I've ran tests with ./scripts/run-tests.sh and made sure all tests are passing

Nope, sorry.I'm on Windows platform and my virtual machine crashed.But this test will run in GitHub Action tests and we can see if this workflow is successful.

Summary

pre-commit is more easier to use and it can effectively prevent developers from forgetting to run the linters.And, it can intergrate many checks into one command.

Test Plan

N/A

WangGithubUser avatar Aug 08 '23 05:08 WangGithubUser