facebook
Migration docusaurus 2
Hello @yangshun , @endiliey review this pr when you got time.
I was working on migrating docusaurus of this repo to new V2 version
Deployed at https://thakurkarthik.github.io/redex/ for testing.
This pr on successful merge takes the docusaurus version to new v2 alpha for fbredex
This PR belongs to #426 and https://github.com/facebook/docusaurus/issues/1834
Here are some screenshots of the new site.
Landing Page
Docs Page
FAQ Page
@yangshun @endiliey i have pushed my code,can you make some time and review it Thanks !
@ThakurKarthik I think there are conflicts now. Could you resolve them?
From Redex site could @int3 help? Or I can do the reviewing instead and preserve as much of v1 design and functionality as possible.
@yangshun i haved merged with latest master now there should be no conflicts.
I'm not too picky... would be nice to keep some of the old button/grey background styling, but I don't think it matters too much. I'm not a designer anyway :p
If you can fix the fonts I'm happy to merge this
Hey Jez, the font is not displaying correctly now because the font files weren't loaded.
As a side note, as part of our standardizing our open source documentation designs, we'd like to encourage projects to stick with the default theme font, which is this case is the system font.
Examples of Docusaurus 2 sites with a consistent font:
https://v2.docusaurus.io https://create-react-app.dev https://cli.dev https://hermesengine.dev
Are you agreeable with that? If so, we could remove the Lato font styles from the CSS.
On Wed, Oct 30, 2019, 7:30 PM Jez Ng [email protected] wrote:
I'm not too picky... would be nice to keep some of the old button/grey background styling, but I don't think it matters too much. I'm not a designer anyway :p
If you can fix the fonts I'm happy to merge this
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/facebook/redex/pull/429?email_source=notifications&email_token=AAKBCHMAC2TQDKTSKYBQSNDQRFV53A5CNFSM4JBHFTG2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECT2IGQ#issuecomment-547857434, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAKBCHMZHHGCO4NOROFBJR3QRFV53ANCNFSM4JBHFTGQ .
@ThakurKarthik could you remove the font styling in the CSS file? Then I think it should be good.
Is this pull request ready to merge now? Has all the feedback been incorporated? Are all the reviewers happy?
Hey @justinjhendrick not sure if it the code is working anymore as docusaurus has gone through major changes i guess !