react icon indicating copy to clipboard operation
react copied to clipboard

Fix ref.current error during render initialization

Open vishwamartur opened this issue 1 year ago • 2 comments

Related to #30782

Update eslint-plugin-react-compiler to allow ref.current access during render for initialization.

  • Rule Update

    • Modify isReportableDiagnostic function to allow ref.current access during render for initialization.
    • Adjust options object to include allowRefCurrentAccessDuringRender.
  • Test Update

    • Add a new valid test case for ref.current access during render for initialization.
    • Update the invalid test case to reflect the new rule.

vishwamartur avatar Nov 28 '24 08:11 vishwamartur

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 15, 2024 4:52pm

vercel[bot] avatar Nov 28 '24 08:11 vercel[bot]

Hi @vishwamartur!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

facebook-github-bot avatar Nov 28 '24 08:11 facebook-github-bot

This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated.

github-actions[bot] avatar Mar 15 '25 17:03 github-actions[bot]

Hi @vishwamartur, thanks for your contribution. This has already been fixed (see playground example).

In general, we prefer to land fixes to the core validation logic instead of ignoring specific lint strings.

mofeiZ avatar Mar 15 '25 17:03 mofeiZ