react icon indicating copy to clipboard operation
react copied to clipboard

eslint-plugin-react-hooks: Fix international component name compatibility

Open DavidZidar opened this issue 1 year ago • 7 comments

Summary

This fixes compatiblity with international functional component names such as ÄndraVärde in the ESLint rule RulesOfHooks.

The problem is a Regex that only allows component names to start with the characters A-Z when in reality characters from other languages should be supported too.

Fixes #31446

How did you test this change?

I added a unit test and verified that the rule failed just like it does in my own projects, then I did my modification and verified that the tests pass.

DavidZidar avatar Nov 08 '24 10:11 DavidZidar

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 8, 2024 10:33am

vercel[bot] avatar Nov 08 '24 10:11 vercel[bot]

Q

karisoner avatar Feb 08 '25 07:02 karisoner

This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated.

github-actions[bot] avatar Jun 07 '25 15:06 github-actions[bot]

Bump, the issue still isn't solved.

DavidZidar avatar Jun 07 '25 15:06 DavidZidar

Bump (I'd really like to see this work get merged)

dawn-classum avatar Sep 04 '25 01:09 dawn-classum

This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated.

github-actions[bot] avatar Dec 03 '25 02:12 github-actions[bot]

Bump.

DavidZidar avatar Dec 04 '25 21:12 DavidZidar