[compiler][needs cleanup]: stop using function deps in PropagateScopeDepsHIR

Open mofeiZ opened this issue 1 year ago • 1 comments

Stack created with Sapling. Best reviewed with ReviewStack.

#31204
#31203
#31202
#31201
-> #31200
#31199
#31198
#31197

Oct 11 '24 20:10 mofeiZ

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
react-compiler-playground	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 15, 2024 5:06pm

Oct 11 '24 20:10 vercel[bot]

Overall looks good but see fixtures - looks like this causes us to take refs as deps in some cases which isn't quite right

Ohh good catch. Debugged further and it looks like the underlying issue is how we special case ref.current accesses in propagateScopeDeps. Added a fix in #31521 which should also fix this

Nov 12 '24 18:11 mofeiZ