react icon indicating copy to clipboard operation
react copied to clipboard

[compiler] Silence ref-in-render errors in ESLint

Open josephsavona opened this issue 1 year ago • 1 comments

Stack from ghstack (oldest at bottom):

  • -> #30843
  • #30844

We need this for compiler correctness but the false positive rate is a bit too high, let's suppress in ESLint for now.

josephsavona avatar Aug 28 '24 23:08 josephsavona

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 30, 2024 5:46am

vercel[bot] avatar Aug 28 '24 23:08 vercel[bot]

If you decide to merge this, please can you make it an option? Otherwise for people who already upgraded and added hundreds of eslint suppression comments, would have to undo/remove those and then presumably re-add them at some later point in time.

lukpsaxo avatar Sep 18 '24 12:09 lukpsaxo

We need this for compiler correctness but the false positive rate is a bit too high, let's suppress in ESLint for now.

Does this mean that despite this ESLint rule change, the compiler will continue to skip optimizing components which render ref.current? This is being discussed here: https://github.com/pmndrs/zustand/pull/2995

jroitgrund avatar Feb 04 '25 12:02 jroitgrund