react icon indicating copy to clipboard operation
react copied to clipboard

[compiler] Custom type definitions in config

Open mvitousek opened this issue 1 year ago • 1 comments

Stack from ghstack (oldest at bottom):

  • -> #30670

Summary: This PR allows custom type definitions for globals to be loaded in the Forget config. We use a slightly different representation than we do internally, in order to ensure that things are well formed before we pass them to the shape registry. The most fundamental issue is that we introduce a notion of IDs (expected to be unique) for types: we can introduce a type and then refer to that type later by a unique ID in a function return type if we have, for example, a global value that returns itself when called.

mvitousek avatar Aug 13 '24 02:08 mvitousek

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 16, 2024 7:10pm

vercel[bot] avatar Aug 13 '24 02:08 vercel[bot]

This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated.

github-actions[bot] avatar Nov 22 '24 05:11 github-actions[bot]

Closing this pull request after a prolonged period of inactivity. If this issue is still present in the latest release, please ask for this pull request to be reopened. Thank you!

github-actions[bot] avatar Nov 29 '24 05:11 github-actions[bot]