react icon indicating copy to clipboard operation
react copied to clipboard

fix[react-devtools/ci]: fix configurations for e2e testing

Open hoxyq opened this issue 1 year ago • 1 comments

This should fix failing DevTools e2e tests on main.

With these changes, running tests locally successfully passes all cases.

hoxyq avatar May 07 '24 15:05 hoxyq

Comparing: 1d618a9cf36948dbf94aa6a6f2eb9e6a64b52eb0...3d5f1f1cfc214831bbbd840d2bb8563f2c79886b

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.66 kB 6.66 kB = 1.82 kB 1.82 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 492.61 kB 492.61 kB = 87.88 kB 87.88 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.67 kB 6.67 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 498.86 kB 498.86 kB = 88.93 kB 88.93 kB
facebook-www/ReactDOM-prod.classic.js = 591.22 kB 591.22 kB = 103.96 kB 103.96 kB
facebook-www/ReactDOM-prod.modern.js = 567.44 kB 567.44 kB = 100.36 kB 100.36 kB
test_utils/ReactAllWarnings.js Deleted 64.26 kB 0.00 kB Deleted 16.02 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
test_utils/ReactAllWarnings.js Deleted 64.26 kB 0.00 kB Deleted 16.02 kB 0.00 kB

Generated by :no_entry_sign: dangerJS against 3d5f1f1cfc214831bbbd840d2bb8563f2c79886b

react-sizebot avatar May 07 '24 15:05 react-sizebot

I am going to land this to fix the CI and publish a new release of DevTools. If there are any changes you want to request, please leave a comment here, I will publish a forward-fix.

cc @kassens @gnoff

hoxyq avatar May 08 '24 11:05 hoxyq