react icon indicating copy to clipboard operation
react copied to clipboard

Update isConcurrent RTR option usage

Open jackpope opened this issue 1 year ago • 2 comments

Reverting some of https://github.com/facebook/react/pull/27804 which renamed this option to stable. This PR just replaces internal usage to make upcoming PRs cleaner.

Keeping isConcurrent unstable for the next major release in order to enable a broader deprecation of RTR and be consistent with concurrent rendering everywhere for next major. (https://github.com/facebook/react/pull/28498)

  • Next major will use concurrent root
  • The old behavior (legacy root by default, concurrent root with unstable option) will be preserved for React Native until new architecture is fully shipped.
  • Flag and legacy root usage can be removed after RN dependency is unblocked without an additional breaking change

jackpope avatar Mar 12 '24 18:03 jackpope

Comparing: 7d6f1e3c13686272c1d76813992d4e782fcb84e6...2a36964b04a7a4fe69ac7577b4d1724da35d7a5a

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 177.10 kB 177.10 kB = 55.20 kB 55.20 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 177.64 kB 177.64 kB = 55.53 kB 55.53 kB
facebook-www/ReactDOM-prod.classic.js = 593.92 kB 593.92 kB = 104.85 kB 104.85 kB
facebook-www/ReactDOM-prod.modern.js = 577.18 kB 577.18 kB = 101.91 kB 101.91 kB
test_utils/ReactAllWarnings.js Deleted 66.60 kB 0.00 kB Deleted 16.28 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
test_utils/ReactAllWarnings.js Deleted 66.60 kB 0.00 kB Deleted 16.28 kB 0.00 kB

Generated by :no_entry_sign: dangerJS against 2a36964b04a7a4fe69ac7577b4d1724da35d7a5a

react-sizebot avatar Mar 12 '24 18:03 react-sizebot

@eps1lon Yes we can -- I can replace any FB usage. Was planning to make that change in https://github.com/facebook/react/pull/28498 . But it makes more sense here. Updated

jackpope avatar Mar 13 '24 14:03 jackpope