Add Popover API support
Summary
Closes #27479
I tried to update fixtures/attribute-behavior/AttributeTableSnapshot.md but I got error in browser console:
Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'unstable_cancelCallback')
Comparing: dddfe688206dafa5646550d351eb9a8e9c53654a...3578155879917d837d8a2cd7112ba6e5386dd52b
Critical size changes
Includes critical production bundles, as well as any change greater than 2%:
| Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |
|---|---|---|---|---|---|---|
| oss-stable/react-dom/cjs/react-dom.production.min.js | = | 174.46 kB | 174.47 kB | +0.01% | 54.27 kB | 54.28 kB |
| oss-experimental/react-dom/cjs/react-dom.production.min.js | = | 176.31 kB | 176.32 kB | +0.01% | 54.88 kB | 54.88 kB |
| facebook-www/ReactDOM-prod.classic.js | = | 564.48 kB | 564.50 kB | = | 99.37 kB | 99.38 kB |
| facebook-www/ReactDOM-prod.modern.js | = | 548.21 kB | 548.23 kB | = | 96.44 kB | 96.45 kB |
Significant size changes
Includes any change greater than 0.2%:
(No significant changes)
Generated by :no_entry_sign: dangerJS against 3578155879917d837d8a2cd7112ba6e5386dd52b
@Semigradsky thanks for the updates here. #27717 should fix the error from the fixtures app. If you rebase on main you should be able to update the attributes fixture now
@jackpope Now in main branch I have new error in console:
App.js:359 Uncaught (in promise) Error: Tag mismatch. Expected: img
at getRenderedAttributeValue (App.js:359:1)
at getRenderedAttributeValues (App.js:416:1)
at prepareState (App.js:454:1)
at App._callee$ (App.js:823:1)
at tryCatch (runtime.js:65:1)
at Generator.invoke [as _invoke] (runtime.js:303:1)
at prototype.<computed> [as next] (runtime.js:117:1)
at step (fetch.js:461:1)
at fetch.js:461:1
Document title is src (string)
The img tag error appears to be flaky. I get it on some loads but others complete successfully. We should fix this but for the sake of getting this PR merged soon, could you try a few more attempts at recording the fixture here?
@jackpope I have tried several times (more than 5 already) and I always have this error.
i’m very excited for this to land! the browser console errors and linting errors are painful. @Semigradsky @jackpope do either of you know how much of a lift it would be to extend support to include the new toggle and beforetoggle events associated with the Popover API?
Alternate with proper overrides for the attribute-behavior fixture and support for the beforetoggle and toggle events: https://github.com/facebook/react/pull/27981
This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated.
Fixed in https://github.com/facebook/react/pull/27981