react icon indicating copy to clipboard operation
react copied to clipboard

Add support for SyntheticKeyboardEvent `isComposing`

Open bhbs opened this issue 2 years ago • 18 comments

Summary

Fixes #13104

Just added isComposing If we don't have to consider IE, then we don't need a polyfill for this property.

https://caniuse.com/mdn-api_keyboardevent_iscomposing

How did you test this change?

No automated tests found

bhbs avatar Feb 27 '23 13:02 bhbs

Hi @bhbs!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

facebook-github-bot avatar Feb 27 '23 13:02 facebook-github-bot

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

facebook-github-bot avatar Feb 27 '23 14:02 facebook-github-bot

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

facebook-github-bot avatar Feb 27 '23 14:02 facebook-github-bot

Comparing: 90172d12e8f06936ade78ed916397c16a2bec4f8...60077ce214e8a31c3caf9d30c3d07c895cd7d1a2

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 174.94 kB 174.95 kB +0.01% 54.44 kB 54.45 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 177.06 kB 177.08 kB +0.01% 55.12 kB 55.13 kB
facebook-www/ReactDOM-prod.classic.js = 567.28 kB 567.30 kB = 99.85 kB 99.85 kB
facebook-www/ReactDOM-prod.modern.js = 551.14 kB 551.16 kB = 96.94 kB 96.94 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by :no_entry_sign: dangerJS against 60077ce214e8a31c3caf9d30c3d07c895cd7d1a2

react-sizebot avatar Feb 28 '23 02:02 react-sizebot

This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated.

github-actions[bot] avatar Apr 09 '24 19:04 github-actions[bot]

bump

bhbs avatar Apr 10 '24 06:04 bhbs

This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated.

github-actions[bot] avatar Jul 09 '24 23:07 github-actions[bot]

Bump

vkrol avatar Jul 10 '24 06:07 vkrol

This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated.

github-actions[bot] avatar Oct 08 '24 07:10 github-actions[bot]

Bump

vkrol avatar Oct 08 '24 08:10 vkrol

This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated.

github-actions[bot] avatar Jan 06 '25 09:01 github-actions[bot]

Bump

bhbs avatar Jan 06 '25 11:01 bhbs

This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated.

github-actions[bot] avatar Jun 11 '25 01:06 github-actions[bot]

Bump

bhbs avatar Jun 11 '25 02:06 bhbs

This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated.

github-actions[bot] avatar Sep 09 '25 03:09 github-actions[bot]

Bump

bhbs avatar Sep 09 '25 03:09 bhbs

This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated.

github-actions[bot] avatar Dec 08 '25 04:12 github-actions[bot]

Bump

vkrol avatar Dec 08 '25 09:12 vkrol