react icon indicating copy to clipboard operation
react copied to clipboard

fix: remove useless line.

Open jiashuai1002 opened this issue 3 years ago • 6 comments

https://github.com/facebook/react/blob/7a4336c4040bb26d8fe143f96d842acae4c728b5/packages/react-reconciler/src/ReactFiberHooks.old.js#L684

jiashuai1002 avatar Jul 13 '22 01:07 jiashuai1002

this is a .old.js, this file is really used? I´m asking becouse really dont know about this.

pierrybos avatar Jul 13 '22 02:07 pierrybos

Hi , Is this issue is open , i want to work on it.

poojavirgo avatar Jul 13 '22 05:07 poojavirgo

This problem has been fixed in a pr #24912

zhangmo8 avatar Jul 13 '22 07:07 zhangmo8

Oh, im looking for things for contribute too Pierry Bos

Em qua., 13 de jul. de 2022 às 04:38, wegi8 @.***> escreveu:

This problem has been fixed in a pr #24912 https://github.com/facebook/react/pull/24912

— Reply to this email directly, view it on GitHub https://github.com/facebook/react/issues/24911#issuecomment-1182873375, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJ7EMDAZYNWHWRNP7LNU2TVTZW65ANCNFSM53M2YPBA . You are receiving this because you commented.Message ID: @.***>

pierrybos avatar Jul 13 '22 10:07 pierrybos

@pierrybos haha, maybe there are other opportunities for contribution waiting for you.

zhangmo8 avatar Jul 14 '22 01:07 zhangmo8

Why is this line useless?

rickhanlonii avatar Aug 26 '22 11:08 rickhanlonii