react icon indicating copy to clipboard operation
react copied to clipboard
Published 1 month ago • verified publisher icon facebook

Add source maps

Open jasonwilliams opened this issue 4 years ago • 2 comments

Fixes https://github.com/facebook/react/issues/20186

Summary

Attempts to get sourcemaps working.

Status:

  • only the renderChunk is commented out for now as I had to give up with that one
  • Sourcemap generation is slow on the prettier plugin. Maybe sourcemaps aren't needed if we're generating "pretty" views anyway? We should disable this if shouldStayReadable is true.

jasonwilliams avatar Jul 23 '21 19:07 jasonwilliams

This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated.

stale[bot] avatar Jan 08 '22 23:01 stale[bot]

not stale

justingrant avatar Jan 08 '22 23:01 justingrant

It looks like the work done in the following PR is likely to supercede and replace this PR:

  • https://github.com/facebook/react/pull/26446

0xdevalias avatar Mar 27 '23 04:03 0xdevalias

Since the above PR (https://github.com/facebook/react/pull/26446) has been merged, this PR is now obsolete, and can probably be closed out.

0xdevalias avatar Dec 01 '23 21:12 0xdevalias