react-strict-dom icon indicating copy to clipboard operation
react-strict-dom copied to clipboard

Partial polyfill for CSS 'visibility'

Open necolas opened this issue 1 year ago • 1 comments

Implements a partial polyfill for non-inheritable 'visibility'. This does not polyfill the web behavior of being able to selectively override the 'visibility' of elements nested within an element with 'visibility:hidden'.

As result, this patch also removes 'visibility' from the inheritable text styles. Originally visibility was added here simply because it is considered an inheritable property on web, even though we didn't do anything with the property on native. In the context of these polyfills, we're only interested in being able to inherit text styles and cannot do anything with inherited visibility, so there is no functional change to the existing polyfill for inheritable text styles.

Also note that no attempt is made to implement 'collapse' as per W3C spec, as this behavior does not appear to be supported for flex items in Chrome anyway (which behave the same whether 'collapse' or 'hidden' is used.)

necolas avatar Feb 24 '24 00:02 necolas

compressed-size: runtime library

Size change: +0.04 kB Total size: 14.92 kB

Filename: gzip (minify) kB size kB change % change
./packages/react-strict-dom/dist/native.js 12.08 (37.83) +0.04 (+0.08) +0.4% (+0.2%) 🔴
View unchanged
Filename: gzip (minify) kB size kB change % change
./packages/react-strict-dom/dist/dom.js 2.84 (8.81) 0.00 (0.00) 0.0% (0.0%)

github-actions[bot] avatar Feb 24 '24 00:02 github-actions[bot]