react-strict-dom
react-strict-dom copied to clipboard
feat: add `eslint-plugin-react-compiler`
This PR fixes #216
Currently, we're doing a lot of nativeProps.PROP = VALUE; assignments and the compiler doesn't like at all. It throws:
Mutating a value returned from a function whose return value should not be mutated react-compiler/react-compiler
I fixed it by doing shallow copies, but I don't know if this is the right approach. If this is ok I can continue doing the rest.
Tried to dig dive a little and found this: https://github.com/facebook/react/issues/29093#issuecomment-2116484361
The benchmarks/{size, perf} jobs are failing because of this: "In public repositories this action does not work in pull_request workflows when triggered by forks"
See more in https://github.com/peter-evans/create-or-update-comment/issues/76#issuecomment-799847814