react-native icon indicating copy to clipboard operation
react-native copied to clipboard

Implement potential fix for mounting errors during synchronous state updates (v2)

Open rubennorte opened this issue 1 year ago • 3 comments

Summary: This is a new attempt at fixing mounting errors during synchronous state updates after what we tried in https://github.com/facebook/react-native/pull/44015.

That fix didn't work because dispatchMountItems actually makes a copy of the mount items that it's going to process, so when we added the mount items to the list they were actually not being picked up by the current processing.

This changes the fix to expose a new list of mount items being processed, and if that's defined then we add it to the list. Otherwise we process as usual.

Differential Revision: D57107212

rubennorte avatar May 08 '24 15:05 rubennorte

This pull request was exported from Phabricator. Differential Revision: D57107212

facebook-github-bot avatar May 08 '24 15:05 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D57107212

facebook-github-bot avatar May 08 '24 15:05 facebook-github-bot

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 19,495,375 +13
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 22,867,578 +2
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 4290ef5d0d30d33e9bf26eb33d8bda86de0dd1ce Branch: main

analysis-bot avatar May 08 '24 16:05 analysis-bot

This was already merged

rubennorte avatar Jul 31 '24 10:07 rubennorte