react-native icon indicating copy to clipboard operation
react-native copied to clipboard

Parse raw filter props

Open joevilches opened this issue 1 year ago • 3 comments

Summary: Title says it all. Right now this ignores drop-shadow as that will be implemented later. Some of this code will need to be adjusted as it is the one filter that takes multiple amounts. But I feel that can be amended later when we get there - after all the amount parsing code is just casting to a float at the moment, so we are not locking ourselves into anything.

Changelog: [Internal]

Reviewed By: NickGerleman

Differential Revision: D54640629

joevilches avatar May 07 '24 21:05 joevilches

This pull request was exported from Phabricator. Differential Revision: D54640629

facebook-github-bot avatar May 07 '24 21:05 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D54640629

facebook-github-bot avatar May 07 '24 21:05 facebook-github-bot

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 19,495,336 +82
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 22,867,620 +73
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: be09d12667044f237f08af410b2838062eb8e657 Branch: main

analysis-bot avatar May 07 '24 21:05 analysis-bot

This pull request has been merged in facebook/react-native@f340e6e575628f92b94e0b8e81f786148ca43e35.

facebook-github-bot avatar May 08 '24 20:05 facebook-github-bot