react-native icon indicating copy to clipboard operation
react-native copied to clipboard

Plumbing to set filters on Android views

Open joevilches opened this issue 1 year ago • 2 comments

Summary: This works similar to how transform is parsed in that it sets tags on the View to actually update the prop when all the prop setters are done being called since the parsing of the array is not very trivial. Besides that it is pretty simple and just calls into FilterHelper and uses setRenderEffect: https://developer.android.com/reference/android/view/View#setRenderEffect(android.graphics.RenderEffect).

That API is only exposed in version 31 of the SDK so it is gated accordingly.

Reviewed By: NickGerleman

Differential Revision: D54640600

joevilches avatar May 07 '24 21:05 joevilches

This pull request was exported from Phabricator. Differential Revision: D54640600

facebook-github-bot avatar May 07 '24 21:05 facebook-github-bot

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 19,495,449 +67
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 22,867,642 +65
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 958f8e2bb55ba3a2ace9507a48a582f546dd3ec2 Branch: main

analysis-bot avatar May 07 '24 21:05 analysis-bot

This pull request was exported from Phabricator. Differential Revision: D54640600

facebook-github-bot avatar May 08 '24 18:05 facebook-github-bot

This pull request has been merged in facebook/react-native@b0e746e4bb3a27d3aee33d9228e62c8d2e336aef.

facebook-github-bot avatar May 08 '24 20:05 facebook-github-bot

This pull request was successfully merged by @joevilches in b0e746e4bb3a27d3aee33d9228e62c8d2e336aef.

When will my fix make it into a release? | How to file a pick request?

github-actions[bot] avatar May 08 '24 20:05 github-actions[bot]