facebook
chore: Remove deprecated onTextInput callback
Summary:
TextInputs' onTextInput callback was removed way back in React Native 0.62 with https://github.com/facebook/react-native/commit/3f7e0a2c9601fc186f25bfd794cd0008ac3983ab , but remnants of the implementation exists. Let's just remove it altogether?
Changelog:
[IOS] [REMOVED] - Remove deprecated onTextInput callback
Test Plan:
CI should pass
| Platform | Engine | Arch | Size (bytes) | Diff |
|---|---|---|---|---|
| android | hermes | arm64-v8a | 19,410,899 | -34,858 |
| android | hermes | armeabi-v7a | n/a | -- |
| android | hermes | x86 | n/a | -- |
| android | hermes | x86_64 | n/a | -- |
| android | jsc | arm64-v8a | 22,784,325 | -33,966 |
| android | jsc | armeabi-v7a | n/a | -- |
| android | jsc | x86 | n/a | -- |
| android | jsc | x86_64 | n/a | -- |
Base commit: c96c8933745b72148856e62f13553d7a2f5d4f6b Branch: main
@javache has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
@javache merged this pull request in facebook/react-native@24aece35b4a2bf196ad48900cdb8a3ca6ea53288.
This pull request was successfully merged by @Saadnajmi in 24aece35b4a2bf196ad48900cdb8a3ca6ea53288.
When will my fix make it into a release? | How to file a pick request?
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
This pull request has been reverted by deee037c62a7d62a349d34db427b14d3560ddf83.
For my own knowledge, why was this reverted? Was there a reference internally or somewhere else I missed? I had assumed this was just a cleanup task.
For my own knowledge, why was this reverted? Was there a reference internally or somewhere else I missed? I had assumed this was just a cleanup task.
I've resubmitted this as two separate changes. The original change was unsafe when older native clients used a newer version of the JS bundle, as native would emit events no longer supported by JS.
