react-native icon indicating copy to clipboard operation
react-native copied to clipboard

Don't support float enums

Open christophpurrer opened this issue 1 year ago • 0 comments

Summary: Changelog: [General][BREAKING] Don't support 'float' enums in Turbo Modules

  • The current implementation of 'float enums' in C++ does not work as invalid results are returned.
  • At potential fix could still cause rounding errors when crossing language bounaries, e.g. 4.6 can become 4.5599999942..
  • C++ enum classes don't support float: https://eel.is/c++draft/dcl.enum#2.sentence-4

The type-specifier-seq of an enum-base shall name an integral type; any cv-qualification is ignored.

Hence removing the feature of float enums for now

Differential Revision: D52120405

christophpurrer avatar Apr 30 '24 04:04 christophpurrer