react-native icon indicating copy to clipboard operation
react-native copied to clipboard

[iOS] Remove _logWarnIfCreateRootViewWithBridgeIsOverridden

Open zhongwuzw opened this issue 1 year ago • 2 comments

Summary:

Fixes customizeRootView migration comment. cc @cipolleschi

Changelog:

[IOS] [FIXED] - Fixes customizeRootView migration comment

Test Plan:

image

zhongwuzw avatar Apr 26 '24 07:04 zhongwuzw

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 19,460,008 -95
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 22,833,614 -8
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: be06fd4e22a500128d202436600381b8bc17b3f5 Branch: main

analysis-bot avatar Apr 26 '24 08:04 analysis-bot

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar May 01 '24 13:05 facebook-github-bot

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar May 20 '24 09:05 facebook-github-bot

@cipolleschi merged this pull request in facebook/react-native@fbf9c4343ae922013b008a7d855c5927b7113e60.

facebook-github-bot avatar May 20 '24 10:05 facebook-github-bot

This pull request was successfully merged by @zhongwuzw in fbf9c4343ae922013b008a7d855c5927b7113e60.

When will my fix make it into a release? | How to file a pick request?

github-actions[bot] avatar May 20 '24 10:05 github-actions[bot]