[Fabric] img events fixes for ios and android
Summary:
fixes Image events in new architecture #43874
Changelog:
[iOS] [Fixed] - Missing source in onLoad native event arguments
[iOS] [Fixed] - Missing error, responseCode, and httpResponseHeaders in onError native event arguments
[iOS] [Fixed] - Missing loaded and total in onProgress native event arguments
[Android] [Fixed] - Missing progress in onProgress native event arguments
Test Plan:
test using Image section of rn-tester app
before
after
| Platform | Engine | Arch | Size (bytes) | Diff |
|---|---|---|---|---|
| android | hermes | arm64-v8a | 19,443,532 | +32,788 |
| android | hermes | armeabi-v7a | n/a | -- |
| android | hermes | x86 | n/a | -- |
| android | hermes | x86_64 | n/a | -- |
| android | jsc | arm64-v8a | 22,817,048 | +32,778 |
| android | jsc | armeabi-v7a | n/a | -- |
| android | jsc | x86 | n/a | -- |
| android | jsc | x86_64 | n/a | -- |
Base commit: 03a51da727022d96f7f9bbc0840b1409121d0429 Branch: main
@NickGerleman has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
@NickGerleman has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
@NickGerleman can i have the failing test/lint details please
@NickGerleman can i have the failing test/lint details please
this usually fails most of the time as i have seen, it is not due to your changes probably as it happens most of the time
@NickGerleman merged this pull request in facebook/react-native@78ab5f4b836d64b71760754c7cce1315630640c7.
This pull request was successfully merged by @netmaxt3r in 78ab5f4b836d64b71760754c7cce1315630640c7.
When will my fix make it into a release? | How to file a pick request?
@NickGerleman can i have the failing test/lint details please
this usually fails most of the time as i have seen, it is not due to your changes probably as it happens most of the time
In this case, there was internal code using some of the interfaces edited here, so it just took some time to update everything.