react-native icon indicating copy to clipboard operation
react-native copied to clipboard

[Fabric] img events fixes for ios and android

Open netmaxt3r opened this issue 1 year ago • 5 comments

Summary:

fixes Image events in new architecture #43874

Changelog:

[iOS] [Fixed] - Missing source in onLoad native event arguments [iOS] [Fixed] - Missing error, responseCode, and httpResponseHeaders in onError native event arguments [iOS] [Fixed] - Missing loaded and total in onProgress native event arguments [Android] [Fixed] - Missing progress in onProgress native event arguments

Test Plan:

test using Image section of rn-tester app

before image after image

netmaxt3r avatar Apr 05 '24 22:04 netmaxt3r

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 19,443,532 +32,788
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 22,817,048 +32,778
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 03a51da727022d96f7f9bbc0840b1409121d0429 Branch: main

analysis-bot avatar Apr 05 '24 22:04 analysis-bot

@NickGerleman has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar Apr 09 '24 23:04 facebook-github-bot

@NickGerleman has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar Apr 15 '24 19:04 facebook-github-bot

@NickGerleman can i have the failing test/lint details please

netmaxt3r avatar Apr 16 '24 07:04 netmaxt3r

@NickGerleman can i have the failing test/lint details please

this usually fails most of the time as i have seen, it is not due to your changes probably as it happens most of the time

Biki-das avatar Apr 16 '24 11:04 Biki-das

@NickGerleman merged this pull request in facebook/react-native@78ab5f4b836d64b71760754c7cce1315630640c7.

facebook-github-bot avatar Apr 24 '24 23:04 facebook-github-bot

This pull request was successfully merged by @netmaxt3r in 78ab5f4b836d64b71760754c7cce1315630640c7.

When will my fix make it into a release? | How to file a pick request?

github-actions[bot] avatar Apr 24 '24 23:04 github-actions[bot]

@NickGerleman can i have the failing test/lint details please

this usually fails most of the time as i have seen, it is not due to your changes probably as it happens most of the time

In this case, there was internal code using some of the interfaces edited here, so it just took some time to update everything.

NickGerleman avatar Apr 25 '24 00:04 NickGerleman