react-native icon indicating copy to clipboard operation
react-native copied to clipboard

Updated NewAppScreen

Open alexanderblackh opened this issue 1 year ago • 2 comments

Summary:

With the push for the new architecture, it felt appropriate to rename the HermesBadge on the NewAppScreen's Header to NewArchitectureBadge to show the render system being used and in the future, if React Compiler is used. and any other changes that may arrive in the future. Additionally, the NewAppScreen now shows the app's displayName, with a "Powered By React Native"

Changelog:

  • [General] [Changed] - Renamed HermesBadge to NewArchitectureBadge
  • [General] [Changed] - Show the current render system being used
  • [General] [Changed] - NewAppScreen's Header now shows the app's displayName.

Test Plan:

Screenshot attached. To test, simply run and see the changes reflected.

NewAppScreen

alexanderblackh avatar Apr 01 '24 23:04 alexanderblackh

Hi @alexanderblackh!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

facebook-github-bot avatar Apr 01 '24 23:04 facebook-github-bot

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

facebook-github-bot avatar Apr 02 '24 03:04 facebook-github-bot