react-native icon indicating copy to clipboard operation
react-native copied to clipboard

Use semver to compare version in cli instead of custom function

Open zeyap opened this issue 1 year ago • 4 comments

Summary:

Changelog:

[General] [Changed] - Use semver to do version comparison in cli instead of custom fn parseVersion

~~adding test for PR change in https://github.com/facebook/react-native/pull/43712~~

zeyap avatar Apr 01 '24 19:04 zeyap

This pull request was exported from Phabricator. Differential Revision: D55600458

facebook-github-bot avatar Apr 01 '24 19:04 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D55600458

facebook-github-bot avatar Apr 02 '24 21:04 facebook-github-bot

Warnings
:warning: :clipboard: Missing Summary - Can you add a Summary? To do so, add a "## Summary" section to your PR description. This is a good place to explain the motivation for making this change.
:warning: :clipboard: Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.

Generated by :no_entry_sign: dangerJS against a564b55ae29d1e280db35f4084948581f38a6139

github-actions[bot] avatar Apr 02 '24 21:04 github-actions[bot]

This pull request was exported from Phabricator. Differential Revision: D55600458

facebook-github-bot avatar Apr 02 '24 21:04 facebook-github-bot

This pull request has been merged in facebook/react-native@c3d45740cd196e8eda378d61cd9bbb729e2cfcca.

facebook-github-bot avatar Apr 09 '24 00:04 facebook-github-bot

This pull request was successfully merged by @zeyap in c3d45740cd196e8eda378d61cd9bbb729e2cfcca.

When will my fix make it into a release? | How to file a pick request?

github-actions[bot] avatar Apr 09 '24 00:04 github-actions[bot]