react-native icon indicating copy to clipboard operation
react-native copied to clipboard

Add ReactMarkerConstants.CONTENT_APPEARED support on Android

Open Kudo opened this issue 1 year ago • 5 comments

Summary:

Add the ReactMarkerConstants.CONTENT_APPEARED support on Android in bridgeless mode. This is an important marker for TTI measurement.

Changelog:

[ANDROID] [ADDED] - Add the ReactMarkerConstants.CONTENT_APPEARED support on Android in bridgeless mode.

Test Plan:

adding this on RNTesterActivity to see if the log is executed

ReactMarker.addListener { name, tag, instanceKey ->
  if (name == ReactMarkerConstants.CONTENT_APPEARED) {
    Log.i("XXX", "XXX")
  }
}

Kudo avatar Mar 22 '24 16:03 Kudo

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 19,385,117 +1
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 22,760,082 -1
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 44d59ea6f9a1705487314e33de52f7056651ba25 Branch: main

analysis-bot avatar Mar 22 '24 17:03 analysis-bot

appreciated if @cortinico could take a look for this pr.

Kudo avatar Mar 29 '24 17:03 Kudo

cc @rubennorte

cortinico avatar Apr 02 '24 11:04 cortinico

rebase main to fix conflict

Kudo avatar Apr 11 '24 07:04 Kudo

much appreciated if @rubennorte could help to take a look for this pr

Kudo avatar Apr 24 '24 16:04 Kudo