react-native icon indicating copy to clipboard operation
react-native copied to clipboard
verified publisher icon facebook

Fix RCTPerfMonitor not showing up in scene based app

Open ouabing opened this issue 1 year ago • 3 comments

Summary:

Currently RCTPerfMonitor won't show up in scene based app, we should first try to extract the window from the connected scenes, and fallback to the window in UIApplicationDelegate.

Changelog:

[iOS] [Fixed] - Fix RCTPerfMonitor not showing up in scene based app

Test Plan:

  • Tested RCTPerfMonitor in app not using scenes;
  • Tested RCTPerfMonitor in app using scenes in iOS 13 & 14;
  • Tested RCTPerfMonitor in app using scenes in iOS 15+.

ouabing avatar Mar 14 '24 04:03 ouabing

This has been extracted as a helper in RCTKeyWindow already. Can you use that?

javache avatar Mar 14 '24 17:03 javache

Wow thank you @javache , I just updated the PR :)

ouabing avatar Mar 15 '24 04:03 ouabing

I don't know why CI is failed, can I rerun it?

ouabing avatar May 06 '24 05:05 ouabing

@javache has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar May 15 '24 13:05 facebook-github-bot

@javache merged this pull request in facebook/react-native@16775215d5a734288da7147db348824395198407.

facebook-github-bot avatar May 16 '24 09:05 facebook-github-bot

This pull request was successfully merged by abing in 16775215d5a734288da7147db348824395198407.

When will my fix make it into a release? | How to file a pick request?

github-actions[bot] avatar May 16 '24 09:05 github-actions[bot]