react-native icon indicating copy to clipboard operation
react-native copied to clipboard

[0.74.0-rc.0] Specs are generated but not correctly linked to `appmodules`

Open tido64 opened this issue 2 years ago • 3 comments

Old Version

0.73.0

New Version

0.74.0-rc.0

Description

In 0.74.0-rc.0, specs are generated but not correctly linked to appmodules:

  /~/android/app/build/generated/rncli/src/main/jni/rncli.cpp:10:10: fatal error: 'RNWWebStorageSpec.h' file not found
  #include <RNWWebStorageSpec.h>
           ^~~~~~~~~~~~~~~~~~~~~
  1 error generated.

Bisecting nightlies, I found that the first build to fail is 0.74.0-nightly-20240220-e9351f0f8. The one before that, 0.74.0-nightly-20240219-28da7f9f5, builds fine.

Steps to reproduce

git clone https://github.com/microsoft/react-native-test-app.git
cd react-native-test-app
npm run set-react-version 0.74 -- --core-only
yarn
cd example/android
sed -i '' 's/#newArchEnabled/newArchEnabled/' gradle.properties
./gradlew assembleDebug

Affected Platforms

Runtime - Android, Build - MacOS

Output of npx react-native info

n/a

Stacktrace or Logs

n/a

Reproducer

https://github.com/microsoft/react-native-test-app

Screenshots and Videos

No response

tido64 avatar Feb 22 '24 08:02 tido64

:warning: Missing Reproducible Example
:information_source: We could not detect a reproducible example in your issue report. Please provide either:
  • If your bug is UI related: a Snack
  • If your bug is build/update related: use our Reproducer Template. A reproducer needs to be in a GitHub repository under your username.

github-actions[bot] avatar Feb 22 '24 08:02 github-actions[bot]

cc @cortinico

tido64 avatar Feb 22 '24 08:02 tido64

Thanks for reporting this @tido64 Fix is here:

  • https://github.com/react-native-community/cli/pull/2306

This requires a bump of the CLI on the 0.74 branch.

BTW for the future: This:

sed -i '' 's/#newArchEnabled/newArchEnabled/' gradle.properties
./gradlew assembleDebug

can be just this:

./gradlew  assembleDebug -PnewArchEnabled=true

cortinico avatar Feb 22 '24 14:02 cortinico

Fixed in RC1 👍

cortinico avatar Mar 04 '24 17:03 cortinico