Fixes rendering smudges of elements with border for iOS New Architecture

[jankosecki]

Summary:

0.73.0 introduced smudges appearing while rendering screen with elements, which use borderWidth styles as in https://github.com/facebook/react-native/issues/42604.

https://github.com/facebook/react-native/pull/38234 removed a feature flag disableTransactionCommit, which by default was false, meaning that prior to this RCTMountingManager.mm was using CATransaction for rendering (unless feature flag react_fabric:disable_transaction_commit was applied).

This change brings back CATransaction into RCTMountingManager.mm

Changelog:

[IOS] [FIXED] - Fix rendering issues of elements with borderWidth (issue 42604)

Test Plan:

Download reproduction repository from linked issue and apply changes to the local version of react-native. Using Reload button or switching screen should not show any more smudges when rendering elements with borderWidth

[mdvacca]

CC @sammy-SC

[sammy-SC]

This should be resolved by https://github.com/facebook/react-native/commit/5fbdc994f945ee8d834632649e3b82451660e8fe

let me know if you are still seeing an issue.

We don't want to bring bar CATransaction because it has a performance cost associated with it.

[jankosecki]

Amazing, thank you @sammy-SC .

I can confirm it resolves the unwanted behaviour visible in the reproduction repository of the linked issue.

[sammy-SC]

thanks for confirming @jankosecki and sorry for breaking this in the first place.