react-native icon indicating copy to clipboard operation
react-native copied to clipboard
verified publisher icon facebook

Enable varying feature flags in ReactInstanceIntegrationTest, use modern CDP registry by default

Open robhogan opened this issue 2 years ago • 6 comments

Summary: Extends ReactInstanceIntegrationTest to allow varying feature flags in tests, using gtest's parameterised tests.

Exercise this in ConsoleLogTest to test against the modern CDP registry, for which we also needed to modify some initialisation logic to account for the fact that under the modern registry, the page is added by the host, rather than by Hermes DecoratedRuntime.

Changelog: [Internal]

Differential Revision: D53919148

robhogan avatar Feb 19 '24 16:02 robhogan

This pull request was exported from Phabricator. Differential Revision: D53919148

facebook-github-bot avatar Feb 19 '24 16:02 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D53919148

facebook-github-bot avatar Feb 19 '24 16:02 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D53919148

facebook-github-bot avatar Feb 19 '24 17:02 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D53919148

facebook-github-bot avatar Feb 19 '24 18:02 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D53919148

facebook-github-bot avatar Feb 19 '24 22:02 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D53919148

facebook-github-bot avatar Feb 19 '24 22:02 facebook-github-bot

This pull request has been merged in facebook/react-native@f0363f5cf0645c59b928f6b94b75d5cd733cfb2e.

facebook-github-bot avatar Feb 26 '24 15:02 facebook-github-bot