fix(iOS): remove deprecated method from RCTPerfMonitor & fix position

[krozniata]

Summary:

This PR removes usage of deprecated statusBarFrame method in RCTPerfMonitor . Instead RCTPerfMonitor now uses safeAreaInsets which also fixes issue causing Perf Monitor to appear under corner in landscape mode on e.g. iPhone 15 Pro. It also fixes initial position of expanded state which was causing it to render under notch.

Also removed duplicate background color setting

Changelog:

[IOS] [REMOVED] - Remove usage of deprecated statusBarFrame method [IOS] [FIXED] - Fix position of RCTPerfMonitor in landscape mode & expanded mode

Test Plan:

RNTester builds and runs successfully, RCTPerfMonitor works and displays correctly

[krozniata]

@cipolleschi Could you take a look? 👀

[cipolleschi]

Could you perhaps rebase and fix the conflict? 🙏

[krozniata]

@cipolleschi done 👌

[facebook-github-bot]

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[cipolleschi]

Hi there! To set expectations, there are some internal tests that are failing, and I need to understand what's going on. I don't think I'll have time today, and next week I'll be on PTO, so this has to wait until I'm back.

I hope that this won't cause any issue!

[facebook-github-bot]

@cipolleschi merged this pull request in facebook/react-native@258f41a30f5a797c0cfdb256a6824b7284dcc8e2.

[github-actions[bot]]

This pull request was successfully merged by @krozniata in 258f41a30f5a797c0cfdb256a6824b7284dcc8e2.

^{When will my fix make it into a release? | How to file a pick request?}