react-native icon indicating copy to clipboard operation
react-native copied to clipboard

add 'unset' to DimensionValue type

Open SaadAhmadSaddiqui opened this issue 2 years ago • 4 comments

Summary:

Adds the unset property for DimensionValue type as it works.

Test plan:

Create a component button with a height of 56 for example, and pass it style props. When using that component, send styles in the styles prop with a height of unset. Produces no errors on both iOS and Android.

SaadAhmadSaddiqui avatar Feb 15 '24 21:02 SaadAhmadSaddiqui

Hi @SaadAhmadSaddiqui!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

facebook-github-bot avatar Feb 15 '24 21:02 facebook-github-bot

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,500,330 -9,327,997
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 9,754,944 -11,431,848
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 15700626cc9d42e52edeb491fb2bba1f118f62e7 Branch: main

analysis-bot avatar Feb 15 '24 21:02 analysis-bot

Fails
:no_entry_sign:

:clipboard: Missing Changelog - Please add a Changelog to your PR description. See Changelog format

Warnings
:warning:

Can't find the E2E test log for ci/circleci: test_e2e_ios. Job link

:warning:

Can't find the E2E test log for ci/circleci: test_e2e_ios. Job link

Generated by :no_entry_sign: dangerJS against c3e06008584b7653477e078e5f6f8cf27d23f838

github-actions[bot] avatar Feb 15 '24 21:02 github-actions[bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

facebook-github-bot avatar Feb 15 '24 22:02 facebook-github-bot

This PR is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days.

react-native-bot avatar Aug 14 '24 05:08 react-native-bot