facebook
[Android] MapBuffer long support
Summary:
This adds support for 64 bit integer (long) values to MapBuffer. Per the wide gamut color RFC Android encodes wide gamut colors as long values so we need to update MapBuffer to support 64 bit integers as well.
Changelog:
[ANDROID] [ADDED] - Add 64 bit integer (long) value support to MapBuffer
Test Plan:
I've added a test to the MapBuffer test suite. This new API is otherwise currently unused but will be used in subsequent PRs as part of wide gamut color support changes.
| Platform | Engine | Arch | Size (bytes) | Diff |
|---|---|---|---|---|
| android | hermes | arm64-v8a | 17,832,429 | -102,649 |
| android | hermes | armeabi-v7a | n/a | -- |
| android | hermes | x86 | n/a | -- |
| android | hermes | x86_64 | n/a | -- |
| android | jsc | arm64-v8a | 21,186,796 | -106,487 |
| android | jsc | armeabi-v7a | n/a | -- |
| android | jsc | x86 | n/a | -- |
| android | jsc | x86_64 | n/a | -- |
Base commit: 4ecf57ead2a32294cb9ed19088e7cce59702794e Branch: main
@NickGerleman has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
@NickGerleman I dropped the bridge changes to keep this completely focused on MapBuffer.
@NickGerleman has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
@NickGerleman merged this pull request in facebook/react-native@57ed0fb30931979742634a1faa9a4d3b5261e50d.