react-native icon indicating copy to clipboard operation
react-native copied to clipboard
verified publisher icon facebook

Implement the support for the inline code blocks

Open jakub-trzebiatowski opened this issue 2 years ago • 7 comments

Description

Implement the support for the inline code blocks, as proposed here: https://github.com/react-native-community/discussions-and-proposals/issues/695

jakub-trzebiatowski avatar Jan 22 '24 17:01 jakub-trzebiatowski

:warning: Newer Version of React Native is Available!
:information_source: You are on a supported minor version, but it looks like there's a newer patch available - 0.73.2. Please upgrade to the highest patch for your minor or latest and verify if the issue persists (alternatively, create a new project and repro the issue in it). If it does not repro, please let us know so we can close out this issue. This helps us ensure we are looking at issues that still exist in the most recent releases.

github-actions[bot] avatar Jan 22 '24 17:01 github-actions[bot]

:warning: Missing Reproducible Example
:information_source: We could not detect a reproducible example in your issue report. Please provide either:
  • If your bug is UI related: a Snack
  • If your bug is build/update related: use our Reproducer Template. A reproducer needs to be in a GitHub repository under your username.

github-actions[bot] avatar Jan 22 '24 17:01 github-actions[bot]

@cortinico I think we could...

...add labels "Type: Enhancement", "Tech: Fabric", "Tech: React Native Core" ...remove all other labels

I hope that we won't get into a fight with bots thinking that this is a bug!

jakub-trzebiatowski avatar Jan 22 '24 17:01 jakub-trzebiatowski

The first big step in this project was de-duplicating various paths for building Spannable objects on Android:

  • https://github.com/facebook/react-native/pull/39630 (merged 🚀)

This PR is now merged!

Remaining actions:

  • [x] Launch an A/B test to verify this functionality
  • [ ] Analyze the results from the A/B test (March/June/July)
  • [ ] Delete the code left-overs from the A/B test

jakub-trzebiatowski avatar Jan 23 '24 10:01 jakub-trzebiatowski

The second wave of minor changes is now live:

  • https://github.com/facebook/react-native/pull/42597 (merged 🚀)
  • https://github.com/facebook/react-native/pull/42598 (merged 🚀)
  • https://github.com/facebook/react-native/pull/42596 (merged 🚀)
  • https://github.com/facebook/react-native/pull/42595 (merged 🚀)
  • https://github.com/facebook/react-native/pull/42594 (merged 🚀)
  • https://github.com/facebook/react-native/pull/42593 (merged 🚀)
  • https://github.com/facebook/react-native/pull/42592 (merged 🚀)

jakub-trzebiatowski avatar Jan 23 '24 10:01 jakub-trzebiatowski

Wave 3:

  • https://github.com/facebook/react-native/pull/42700 (merged 🚀)
  • https://github.com/facebook/react-native/pull/42701 (in review)
  • https://github.com/facebook/react-native/pull/42703 (approved ✅)
  • https://github.com/facebook/react-native/pull/42704 (in review)

jakub-trzebiatowski avatar Jan 29 '24 11:01 jakub-trzebiatowski

PR with the initial feature implementation:

  • https://github.com/facebook/react-native/pull/43150

jakub-trzebiatowski avatar Feb 22 '24 15:02 jakub-trzebiatowski