react-native icon indicating copy to clipboard operation
react-native copied to clipboard

Docs rot: PixelRatio.getFontScale declaration out of date

Open ahmedsakr opened this issue 2 years ago • 3 comments

Description

PixelRatio.d.ts has out-dated behaviour described for getFontScale - it still claims that it is only supported on android when this is no longer the case as indicated by the react-native-website: https://reactnative.dev/docs/pixelratio#getfontscale

React Native Version

0.72.0

Output of npx react-native info

System: OS: macOS 13.6 CPU: (10) arm64 Apple M1 Pro Memory: 240.28 MB / 32.00 GB Shell: version: "5.9" path: /bin/zsh Binaries: Node: version: 16.20.0 path: ~/.nvm/versions/node/v16.20.0/bin/node Yarn: version: 1.22.17 path: /opt/homebrew/bin/yarn npm: version: 8.19.4 path: ~/.nvm/versions/node/v16.20.0/bin/npm Watchman: Not Found Managers: CocoaPods: version: 1.12.1 path: /opt/homebrew/bin/pod SDKs: iOS SDK: Platforms: - DriverKit 23.0 - iOS 17.0 - macOS 14.0 - tvOS 17.0 - watchOS 10.0 Android SDK: Not Found IDEs: Android Studio: 2022.3 AI-223.8836.35.2231.10671973 Xcode: version: 15.0/15A240d path: /usr/bin/xcodebuild Languages: Java: version: 11.0.12 path: /usr/bin/javac Ruby: version: 3.2.1 path: /Users//.rbenv/shims/ruby npmPackages: "@react-native-community/cli": Not Found react: installed: 18.2.0 wanted: ^18 react-native: installed: 0.72.4 wanted: ^0.72.4 react-native-macos: Not Found npmGlobalPackages: "react-native": Not Found Android: hermesEnabled: true newArchEnabled: false iOS: hermesEnabled: true newArchEnabled: false

Steps to reproduce

Not really a bug but just docs rot that could be misleading when developers view embedded docs through node_modules: https://github.com/facebook/react-native/blob/main/packages/react-native/Libraries/Utilities/PixelRatio.d.ts#L37

Snack, screenshot, or link to a repository

https://github.com/facebook/react-native/blob/main/packages/react-native/Libraries/Utilities/PixelRatio.d.ts#L37

ahmedsakr avatar Sep 28 '23 15:09 ahmedsakr

:warning: Newer Version of React Native is Available!
:information_source: You are on a supported minor version, but it looks like there's a newer patch available - 0.72.5. Please upgrade to the highest patch for your minor or latest and verify if the issue persists (alternatively, create a new project and repro the issue in it). If it does not repro, please let us know so we can close out this issue. This helps us ensure we are looking at issues that still exist in the most recent releases.

github-actions[bot] avatar Sep 28 '23 15:09 github-actions[bot]

:warning: Missing Reproducible Example
:information_source: We could not detect a reproducible example in your issue report. Please provide either:
  • If your bug is UI related: a Snack
  • If your bug is build/update related: use our Reproducer Template. A reproducer needs to be in a GitHub repository under your username.

github-actions[bot] avatar Sep 28 '23 15:09 github-actions[bot]

This issue is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar Apr 03 '24 05:04 github-actions[bot]

This issue was closed because it has been stalled for 7 days with no activity.

github-actions[bot] avatar Apr 10 '24 05:04 github-actions[bot]