react-native icon indicating copy to clipboard operation
react-native copied to clipboard

Add ability to get ShadowNodeFamily's ancestors as shared pointers

Open vincentriemer opened this issue 2 years ago • 4 comments

Summary: Changelog: [Internal] - Add ability to get ShadowNodeFamily's ancestors as shared pointers

While working on the hover tracking logic I've found the need to recieve a node's ancestor list to contain shared pointers to ShadowNodes instead of references to them. This isn't necessarily to get ownership of the ancestors but instead will allow me to store those shadow node lists as weak pointers so I have a mechanism to know when they've been deallocated.

RFC: This effectively just adds a copy of the existing getAncestors method with minor changes. This creates some code duplication but I'm unsure of a more elegant way to do this so I'm open to ideas.

Differential Revision: D48170045

vincentriemer avatar Aug 08 '23 21:08 vincentriemer

This pull request was exported from Phabricator. Differential Revision: D48170045

facebook-github-bot avatar Aug 08 '23 22:08 facebook-github-bot

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,956,135 +7,226
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 9,549,485 +7,236
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 910a9567f42f65971c480eac7c8eb65a56c14361 Branch: main

analysis-bot avatar Aug 08 '23 22:08 analysis-bot

This pull request was exported from Phabricator. Differential Revision: D48170045

facebook-github-bot avatar Aug 21 '23 16:08 facebook-github-bot

This PR is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar Feb 18 '24 05:02 github-actions[bot]

This PR was closed because it has been stalled for 7 days with no activity.

github-actions[bot] avatar Feb 25 '24 05:02 github-actions[bot]