react-native icon indicating copy to clipboard operation
react-native copied to clipboard

Delete StandardCharsets from codebase

Open mdvacca opened this issue 2 years ago • 6 comments

Summary: StandardCharsets was deprecated and marked for removal, since 0.73 was released we can now safely delete it

changelog: [Android][Deleted] Delete StandardCharsets class, please use java.nio.charset.StandardCharsets instead

Differential Revision: D47306709

mdvacca avatar Jul 07 '23 22:07 mdvacca

This pull request was exported from Phabricator. Differential Revision: D47306709

facebook-github-bot avatar Jul 07 '23 22:07 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D47306709

facebook-github-bot avatar Jul 08 '23 00:07 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D47306709

facebook-github-bot avatar Jul 08 '23 00:07 facebook-github-bot

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 9,001,464 -1
android hermes armeabi-v7a 8,255,380 +1
android hermes x86 9,510,509 -3
android hermes x86_64 9,356,372 -1
android jsc arm64-v8a 9,614,530 -1
android jsc armeabi-v7a 8,741,031 +0
android jsc x86 9,701,387 +0
android jsc x86_64 9,947,947 +0

Base commit: 28dfdb22ebaff7055fd8bb4b8847e018181f849d Branch: main

analysis-bot avatar Jul 08 '23 00:07 analysis-bot

This pull request was exported from Phabricator. Differential Revision: D47306709

facebook-github-bot avatar Jul 08 '23 15:07 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D47306709

facebook-github-bot avatar Jul 08 '23 17:07 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D47306709

facebook-github-bot avatar Jul 10 '23 16:07 facebook-github-bot

Closing as abandoned internally

cortinico avatar Oct 23 '23 14:10 cortinico