react-native icon indicating copy to clipboard operation
react-native copied to clipboard

[iOS] expose keyCode in onKeyPress event (TextInput)

Open robertherber opened this issue 2 years ago • 3 comments

Summary

This exposes the ios keyCode to onKeyPress events. This makes it possible to support richer keyboard interactions, like in react-native-hotkeys which provides a uniform interface for both web and iOS.

Changelog

[IOS] [ADDED] - Added iosKeyCode to onKeyPress events for iOS 13.4+

Test Plan

This is used live in conjunction (with patch-package) with react-native-hotkeys in https://www.schedulist.app/. All it does is expose an additional property containing the iOS key code to onKeyPress events.

robertherber avatar Mar 09 '23 11:03 robertherber

Hi @robertherber!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

facebook-github-bot avatar Mar 09 '23 11:03 facebook-github-bot

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

facebook-github-bot avatar Mar 09 '23 12:03 facebook-github-bot

@ryancat Why is the CircleCI Pipeline failing? Seems to fail at start..

robertherber avatar Mar 09 '23 14:03 robertherber

This PR is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar Sep 06 '23 05:09 github-actions[bot]

This PR was closed because it has been stalled for 7 days with no activity.

github-actions[bot] avatar Sep 13 '23 05:09 github-actions[bot]

@ryancat Could you please reopen this?

robertherber avatar Sep 13 '23 10:09 robertherber