react-native icon indicating copy to clipboard operation
react-native copied to clipboard

rename App-test.tsx to App.test.tsx

Open Adnan-Bacic opened this issue 3 years ago • 1 comments

Summary

The starter test file when creating a create-react-app project is App.test.js, while in react-native its App-test.js(recently changed to .tsx instead of .js)

This aims to unify the naming convention between create-react-app and react-native init.

Originally suggested here: https://github.com/react-native-community/discussions-and-proposals/discussions/570

Changelog

[GENERAL] [CHANGED] - Renamed App-test.tsx to App.test.tsx to unify naming convention with create-react-app

Test Plan

  1. cd template
  2. yarn
  3. yarn test

The test inside __tests__/App.test.tsx should (still) pass

Adnan-Bacic avatar Jan 13 '23 13:01 Adnan-Bacic

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,493,485 +0
android hermes armeabi-v7a 7,813,452 +0
android hermes x86 8,967,867 +0
android hermes x86_64 8,827,371 +0
android jsc arm64-v8a 9,679,111 +0
android jsc armeabi-v7a 8,412,818 +0
android jsc x86 9,742,216 +0
android jsc x86_64 10,220,841 +0

Base commit: 8befb740d6cd3de6ead067ac01b70c37d4b5b1bc Branch: main

analysis-bot avatar Jan 13 '23 13:01 analysis-bot

@NickGerleman has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar Jan 16 '23 08:01 facebook-github-bot

@NickGerleman merged this pull request in facebook/react-native@3c03aef1511844262f38149ad261e26703f55ead.

facebook-github-bot avatar Jan 16 '23 11:01 facebook-github-bot